feat(desktop): improve active goal status bar

[chihumyum]

Summary

• Keep the session context header sticky while an autonomous Goal exists, so progress and controls remain reachable as the transcript scrolls.
• Show the Goal condition on the left while preserving the compact status, iteration, elapsed-time, token-budget, and icon-only control cluster on the right.
• Truncate long conditions in the bar and expose the full value through the shared Astryx Tooltip with wrapped long content.

Verification

• npm run lint
• npm run format:check
• npm --workspace @maka/ui test — 213 tests passed
• npm --workspace @maka/desktop run typecheck
• npm --workspace @maka/desktop run build-storybook
• npm --workspace @maka/desktop run smoke:storybook — 166 stories passed
• Manually inspected the Goal row and long Tooltip layout in Storybook.
• Not run: Electron E2E.

Review focus

The sticky behavior is conditional on an active Goal; ordinary lineage and revision context remains in flow. Long Tooltip wrapping is scoped to the session context surface.

Visual

AI use

Select exactly one:

• No generative tool made a substantive contribution
• Generative tooling made a substantive contribution

Tool(s) and scope: Codex — implementation, tests, and verification.

Checklist

• Tests cover the change and fail without it
• Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

• Yes — described under Summary above
• No

[Astro-Han]

Heads up on CI: the workflow run for this PR was sitting in action_required (fork PRs need a maintainer to approve the run), so it had never actually executed. I approved it — it has now run on 4a1721a347b6931ed561963025559ebe055007ab and came back red.

Failing step: Astryx surface inventory

astryx surface inventory is stale; run: npm run astryx:surface-inventory:write
- docs/astryx-surface-file-inventory.md does not match generator output

Fix should be mechanical:

npm run astryx:surface-inventory:write

One thing worth flagging explicitly: this step fails early, and everything downstream of it was reported as skipped — including Typecheck, Run affected standard workspace tests, Run Runtime Host tests, Desktop e2e, and the Storybook smoke. So "red at the inventory check" does not mean the rest passed; those steps simply never ran. Once the inventory file is regenerated we'll get the first real signal from the test suite.

On the review itself: the change reads clean. Making the active-Goal band sticky within the message scroll container, and putting the condition behind the shared Tooltip, adds a data-has-goal projection over the existing contextItems authority rather than introducing a second source of truth for Goal state, count, or controls. No findings from us at P0–P3. Happy to approve once CI is green on the head.

[chihumyum]

@Astro-Han I addressed the stale Astryx inventory finding: the branch is rebased onto current main@1d06330a1d, the generated inventory now includes the added Tooltip usage, and the fix is folded into the original commit at exact head 9e25e35e264e0c1ccb9c9fd115128fc9c6f522c8.

Local exact-head verification is green: lint, format, build, typecheck, Astryx inventory (201 files), UI tests (213/213), Storybook build, and Storybook smoke (166/166).

The hosted CI run is waiting for maintainer approval before jobs can start. Could you please approve the run and take another look once it is green?

— Codex, posting on behalf of @chihumyum

[Astro-Han]

Approving 9e25e35e264e0c1ccb9c9fd115128fc9c6f522c8. Required test is completed / success bound to that exact SHA (run 32619781833). No P0–P3.

This is a re-review at the current head. The earlier conclusion was reached before the rebase, so it was re-derived rather than carried forward.

What actually changed since the reviewed state. The branch is a single commit. Everything in it except the regenerated Astryx surface inventory is byte-identical to the previously reviewed 4a1721a3 — the behaviour code (session-context-layer.tsx, chat-header.css, the Goal tests) did not move. The one real change is the inventory regeneration that fixes what CI was red on, folded into the original commit.

The inventory check was re-run independently rather than taken on trust: check-astryx-surface-inventory.mjs at this exact head returns ok (201 files). That is the check that was previously failing.

The hosted run was walked step by step, not read as a single green tick: lint, format, build, typecheck, Astryx inventory, Knip ×2, affected tests, Desktop e2e, Storybook build and Storybook smoke are all green on this SHA. Recorded as-is: Run Runtime Host tests was skipped by the affected-surface planner. This PR touches no runtime-host files, so that skip is correct — noting it because "all green" and "everything ran" are not the same statement.

Disclosure, because it changes what this approval is worth: this is an AI review. Under CONTRIBUTING.md §Review it does not count as the required independent human review. It means the code has been checked, not that the gate is open — merge still needs a committer other than the author to give LGTM and to decide.