Rewrite the site index and download pages - #181
Draft
slachiewicz wants to merge 1 commit into
Draft
Conversation
Sentence-cases five headings, which changes their generated ids. The previous ids are kept as explicit anchors so no published link breaks; do not drop those anchors when editing these headings. Adds an introductory sentence to the Mirrors section, which had none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative proposal for the same two files as #173, offered so the two passes can be compared side by side. Only one of them should land.
Points that the diff does not show:
Proxy_SettingstoProxy_settings, and the same for Local Repository, Remote Repositories, Offline Mode, and Output Artifacts). The former ids are preserved as explicit<a id>anchors, so no published link breaks.maven-site-plugin3.22.0 keeps those anchors; on 3.21.0 and earlier they are dropped.More informationwas a second<h1>on the page. It is now an<h2>.The properties are prefixed with the ref id of the <pom> element, e.g. ${pom.version}is ambiguous about what the prefix is. The rewrite names the id and the resulting property separately.Verified:
mvn siteon this branch, then the renderedtarget/site/index.htmlanchors diffed against https://maven.apache.org/resolver-ant-tasks/index.html. No published anchor is missing, five are added, and no id is duplicated.This change was created with AI assistance.