Fix sal encoding-dispatch#488
Open
leginee wants to merge 1 commit into
Open
Conversation
…able bugs Impl_getTextEncodingData() is a positional array indexed by the ABI-frozen rtl_TextEncoding enum. #i119141 removed the ISCII converter but deleted its array slot with no NULL placeholder, shifting JAVA_UTF8, ADOBE_STANDARD, ADOBE_SYMBOL, PT154 and ADOBE_DINGBATS onto the wrong converter. Restore the NULL slot and add a compile-time size guard. Wiring ADOBE_DINGBATS correctly surfaced three latent ZapfDingbats table errors (0x6C→U+25CF; reverse range to U+2797; circled-digits reverse start 0xAC); fix all three. Update rtl_textcvt qa: park the now-unimplemented ISCII behind TEST_ISCII_DEVANAGARI, correct the ISCII Windows codepage to 57002.
leginee
force-pushed
the
Fix-sal-encoding-dispatch
branch
from
8121fd3 to
5b2517d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the second out of 3 fixes from test migration. This is about the ISCII encoding has been removed. The removal resulted in a array to enumn mismatch. After the enumn and the array fitted together, some encoding typos appeared.
enumn has been untouched for ABI compatibility on our Interface.
commit message for convenience
Fix sal encoding-dispatch off-by-one (ISCII removal) + ZapfDingbats table bugs
Impl_getTextEncodingData() is a positional array indexed by the ABI-frozen rtl_TextEncoding enum. #i119141 removed the ISCII converter but deleted its array slot with no NULL placeholder, shifting JAVA_UTF8, ADOBE_STANDARD, ADOBE_SYMBOL, PT154 and ADOBE_DINGBATS onto the wrong converter. Restore the NULL slot and add a compile-time size guard.
Wiring ADOBE_DINGBATS correctly surfaced three latent ZapfDingbats table errors (0x6C→U+25CF; reverse range to U+2797; circled-digits reverse start 0xAC); fix all three. Update rtl_textcvt qa: park the now-unimplemented ISCII behind TEST_ISCII_DEVANAGARI, correct the ISCII Windows codepage to 57002.