Add Increase and Decrease Font Size Shortcuts#88
Conversation
Fix for issue #54923
|
Just for conformity with other office applications: Setting these hotkeys by hand works for me, but the underlying function does not work as expected. |
|
I think maybe this should discussed on dev@ to get some consensus on the key combination that would be appropriate because of the ramifications of this addition. |
|
i have the case reviewed. Why decrease specifically failsOn a US/UK keyboard, < is physically Shift+comma, so pressing "Ctrl+<" generates a key event of KEY_LESS + SHIFT + MOD1. But the PR binds decrease to LESS_MOD1 = KEY_LESS + MOD1 (no shift). The event carries SHIFT, the binding doesn't → no match → shrink never fires. Increase works only by luck of the asymmetry: > is Shift+period, generating KEY_GREATER + SHIFT + MOD1, and the PR happens to bind it to GREATER_SHIFT_MOD1 — which does include SHIFT, so it matches. So the same one-character inconsistency I flagged is precisely what users are reporting. The fix is LESS_MOD1 → LESS_SHIFT_MOD1. (This also explains why Pilot-Pirx said setting it by hand worked — he'd have entered a consistent combo.) The separate "jumps by 2" complaint const SwTwips lFontInc = 2 * 20; // +/- 2pt (txtattr.cxx:78) Net verdict on PR #88Binding bug (real, fixable): decrease broken by the missing SHIFT → change to LESS_SHIFT_MOD1. |
Fix for issue #54923
Ctrl + > to increase
Ctrl + < to decrese