Keep converter outputs aligned with root schema - #306
Open
LiangRuoShui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The published core JSON Schema only allows
versionandsemantic_modelat the document root and setsadditionalProperties: false. dbt and Honeydew could still emit root-level advertisement fields (dialects/vendors), and the PythonOSIDocumentmodel accepted those fields, which allowed generated OSI documents to fail the official validator.What changed
dialectsemission from the dbt MSI-to-OSI converter.vendorsemission from the Honeydew-to-OSI converter.vendorsanddialectson OSI input.OSIDocumentmodel reject schema-invalid root extra fields.Tests added/updated
dialectsandvendorswhile preserving expression-level dialects.vendors/dialectsare rejected.dialectsis rejected.Verification
uv run validation/validate.py examples/tpcds_semantic_model.yamlcd python && uv run --with pytest pytest -qcd converters/dbt && uv run pytest -qcd converters/honeydew && uv run pytest -q