[GH-3362] Move Shapefile and GeoParquet metadata readers into Spark common - #3363
Open
jiayuasu wants to merge 1 commit into
Open
[GH-3362] Move Shapefile and GeoParquet metadata readers into Spark common#3363jiayuasu wants to merge 1 commit into
jiayuasu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Yes, I have read the Contributor Rules and Contributor Development Guide.
Is this PR related to a ticket?
Yes, and the PR name follows the format
[GH-XXX] my subject. Closes #3362.What changes were proposed in this PR?
Move the identical Shapefile reader and GeoParquet metadata reader implementations from the Spark 3.5, 4.0, and 4.1 modules into
spark/common:Packages, public APIs, dependencies, and behavior remain unchanged. This is separate from the GeoPackage refactor in #3361; GeoPackage files are unchanged here.
How was this patch tested?
spark-shadedreactor builds for Spark 3.5 / Scala 2.12, Spark 4.0 / Scala 2.13, and Spark 4.1 / Scala 2.13:mvn -q clean package -pl spark-shaded -am -Dspark=<version> -Dscala=<version> -DskipTests -Dmaven.javadoc.skip=trueShapefileTests(34 tests),GeoParquetMetadataTests(7 tests), andgeoparquetIOTests(54 tests) sequentially on each Spark version. All 95 tests passed both with common-module production classes only and with the freshly built shaded JAR, for six successful runs.git diff --checkpassed.Did this PR include necessary documentation updates?
No, this PR does not affect any public API so no need to change the documentation.