Repository navigation
[ISSUE #654] Raise minimum Node.js to 22 LTS and modernise CI workflows - #721
Merged
Merged
Conversation
…CI workflows Node 18 and 20 are both end-of-life, while package.json still declared "node": ">=8.0.0" and the workflows pinned Node 16/20 on deprecated action versions. - package.json: engines.node >= 22.12.0, the floor commander@15 requires - .nvmrc: 22 - README: Node 22 LTS or newer, 24 recommended - build.yml: matrix [22.x, 24.x], checkout@v4, setup-node@v4 with npm cache - deploy.yml: checkout@v4, setup-node@v4, build on Node 24 - sync-to-main.yml: build on Node 24 instead of 16 Two details the matrix change would otherwise have broken silently: - the lint step was gated on matrix.node-version == '20.x' and would have stopped running; it now runs on 22.x - the coverage artifact had a fixed name, which actions/upload-artifact@v4 rejects when two matrix jobs upload it; the name now carries the version Verified locally on Node v24.21.0 (Windows): npm ci, npm run build (compiled successfully with no NODE_OPTIONS), npm run test:coverage (56 suites / 281 tests) and npm run lint all pass.
dengliming
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #654.
Node 18 and 20 have both reached end-of-life, while
package.jsonstill declared"node": ">=8.0.0"and the workflows pinned Node 16/20 on deprecated action versions.Changes
package.jsonengines.node→>=22.12.0, the floorcommander@15requires.nvmrc20→22README.md.github/workflows/build.yml[22.x, 24.x],checkout@v4,setup-node@v4withcache: npm.github/workflows/deploy.ymlcheckout@v4,setup-node@v4, build on Node 24.github/workflows/sync-to-main.ymlTwo things the matrix change would otherwise have broken silently
if: matrix.node-version == '20.x'. With the matrix moved to[22.x, 24.x]that condition can never match, so lint would stop running with no erroranywhere. It now runs on
22.x.unit-test-coverage.actions/upload-artifact@v4rejects a second upload under a name already used in the same run, so with two matrix jobs
the workflow would have failed. The name now carries the Node version.
Verification
Local, on Node v24.21.0 (Windows):
npm cinpm run buildCompiled successfully, with noNODE_OPTIONSand no--openssl-legacy-providernpm run test:coveragenpm run lintThis answers the open question in #654 about whether the roadhog build needs the legacy
OpenSSL provider on modern Node: on Node 24 it does not. Node 22 is covered by the new CI
matrix rather than locally.
Deliberately out of scope: the
caniuse-litedata warning,typescript@2.9.2, the bundlesize and the
npm auditfindings. All real, none of them this issue.Generative AI assistance (Claude) was used while investigating this issue and preparing the
change, per the ASF Generative Tooling Guidance. The changes and the verification above are
mine and I take responsibility for them.