SOLR-18286: Add Changelog Types Reference to developer documentation#4530
SOLR-18286: Add Changelog Types Reference to developer documentation#4530abumarjikar wants to merge 3 commits into
Conversation
janhoy
left a comment
There was a problem hiding this comment.
I don't think we need a changelog entry for a doc change like this - it makes no sense in context of the shipped Solr tgz to mention that a developer doc has changed.
Else, this is a nice clarification, thanks.
Then a comment, not on your doc but in general about the security type. A security type would not be mutually exclusive with the other types. A change regarding a security issue would always also either be added, changed, deprecated, removed or fixed. I know it is a type recommended by https://keepachangelog.com/en/1.1.0/#how but in practice we never or rarely flag something as security until after a release?
dsmiley
left a comment
There was a problem hiding this comment.
What was the source of you writing this; did you guess? I suspect so as it doesn't have "other". See
Lines 70 to 79 in 232690c
| | For any bug fixes or corrections to unintended behavior. | ||
| | Fixing a `NullPointerException`, correcting data corruption issues, or resolving UI glitches. | ||
|
|
||
| | security |
There was a problem hiding this comment.
@janhoy lets drop this. This is an independent cross-cutting concern. Perhaps we might have a separate loose tagging mechanism with values like "security", "dependency", "perf" -- or just not bother.
|
Changes made as per the review. |
|
Just want to point out we'll have double maintenance of the same info duplicated in |
janhoy
left a comment
There was a problem hiding this comment.
This is fine.
Regarding security type, I se in https://solr.apache.org/docs/10_0_0/changes/Changes.html that that type is only ever used three times in our entire changelog history. So we can do a followup PR to move those three to other section and formally remove it as a valid type across all tooling and workflows.
https://issues.apache.org/jira/browse/SOLR-18286
Description
This PR introduces a structured "Changelog Types Reference" guide to the developer documentation (dev-docs/changelog.adoc). It explicitly defines the intended use cases for each changelog classification type (added, changed, deprecated, removed, fixed, and security) to ensure consistency across community contributions and release notes.
Solution
dded an explicit AsciiDoc reference table in dev-docs/changelog.adoc categorizing each valid changelog type with its description and concrete examples.
Tests
No programmatic tests were written as this is a pure documentation update. Verified local formatting layout for the AsciiDoc table preview structure.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.