You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(workflow-form): a rebuild that arrives while the reader is typing is dropped instead of held (from #8437) #8497
On the Form View, a rebuild of the input cards that arrives while the focus is inside a form control is discarded rather than postponed. Two paths reach it:
Compilation finishes while a reader is typing in a card: the schema refresh (for example the column names an attribute dropdown offers) never lands until the next compile or a reload.
With feat(gui): author the Form View in place with an edit mode #8455's edit mode: ticking a property in the step panel to expose it. The tick box is an <input type="checkbox"> inside the page, so it has the focus at the moment the change fires; the rebuild is dropped and the card only appears after some unrelated rebuild or a refresh. Unticking behaves the same way.
Expected: the rebuild runs as soon as it safely can. A tick box is not typing, so its rebuild should run at once; a rebuild that does arrive mid-typing should run when the focus leaves the field, not vanish.
Root cause: isTypingInTheForm() (from #8437) counts any focused INPUT inside the page as typing, tick boxes included, and both subscribers (getCompilationStateInfoChangedStream, formBindingChanged$) return when it says so. Nothing runs the emission later.
Fix: only text-like inputs, textareas, selects and content-editables count as typing; a rebuild that arrives while typing is held and runs once the focus leaves the text control (focusout, decided a tick later so tabbing to the next text field keeps it held). Found while verifying #8455 (parent #8011). #8455 carries the same change so it stays self-contained; whichever merges first, the other rebases and the duplicate hunk disappears.
How to reproduce?
On main (reader path):
Open a workflow in the Form View with an exposed attribute input.
Put the cursor in a text input and, while it is focused, cause a compile (for example a co-editor changes an upstream operator on the canvas).
The attribute dropdown keeps its old column list until the next compile or a reload.
It looks like the issue description doesn't quite follow our template yet:
This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see CONTRIBUTING.md for the full contribution flow.
Activity
github-actions commentedon Sep 11, 2026
👋 Thanks for opening this issue, @yangzhang75!
It looks like the issue description doesn't quite follow our template yet:
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see CONTRIBUTING.md for the full contribution flow.
yangzhang75 commentedon Sep 11, 2026
/take
fix(workflow-form): hold a rebuild that arrives while typing instead …
fix(workflow-form): hold a rebuild that arrives while typing instead …
fix(workflow-form): hold a rebuild that arrives while typing instead …