You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(workflow-form): a result update rebuilds the visualization frame on every emission #8759
The Form View keys each chart frame by a per-operator resultVersion and bumps it for every operator in every getResultUpdateStream() emission (workflow-form.component.ts:349-357). Each bump changes the frame's *ngFor identity, so the visualization iframe is destroyed and recreated on every update. That defeats VisualizationFrameContentComponent's own throttled (auditTime 2 s) in-place self-update: during a run the chart flickers and re-fits on each emission instead of updating in place.
The key exists for a reason (#8441): the chart reads its content once at creation, and a reused frame showed "undefined" for a genuinely new result.
Expected: the frame is rebuilt only when a result is genuinely new -- its first appearance, or a re-run -- and updates in place otherwise. clearResults is a separate stream and has to be handled so a re-run still gets a fresh frame, without bringing the stale/undefined-picture bug back.
Part of #8439 (the result-frame rebuild churn item) and the Form View feature #8011. From the #8441 review.
How to reproduce?
Open a workflow in the Form View whose shown result is a visualization, on a run that emits many result updates (a slow pipeline).
Watch the chart during the run: it is recreated on each emission (the iframe element's identity changes; the frame's content request repeats) rather than updating in place.
Has to be verified on a flag-on instance: the iframe cannot render in jsdom, so the unit tests can only pin when the key changes.
It looks like the issue description doesn't quite follow our template yet:
This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see CONTRIBUTING.md for the full contribution flow.
Activity
github-actions commentedon Sep 29, 2026
👋 Thanks for opening this issue, @yangzhang75!
It looks like the issue description doesn't quite follow our template yet:
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
You can find the template prompts by editing the description, or see CONTRIBUTING.md for the full contribution flow.
yangzhang75 commentedon Oct 5, 2026
/take