Skip to content

build: read the fork options once, outside the grouping loop #8369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kz930 wants to merge 1 commit into from
Closed

build: read the fork options once, outside the grouping loop #8369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,14 @@
Test / fork := true,
Test / forkOptions := (Test / forkOptions).value
.withWorkingDirectory((ThisBuild / baseDirectory).value),
Test / testGrouping := (Test / definedTests).value.map { suite =>
Tests.Group(suite.name, Seq(suite), Tests.SubProcess((Test / forkOptions).value))
Test / testGrouping := {
// Read once, outside the loop: sbt lifts a `.value` written inside a lambda to

Check warning on line 231 in build.sbt

View workflow job for this annotation

GitHub Actions / Bench 

The evaluation of `/` inside an anonymous function is prohibited.
// the top of the task anyway, so leaving it there reads as one lookup per suite
// when it is not, and sbt warns about exactly that.
val forked = (Test / forkOptions).value
(Test / definedTests).value.map { suite =>
Tests.Group(suite.name, Seq(suite), Tests.SubProcess(forked))
}
}
)

Expand Down
Loading