Skip to content

feat(workflow-operator): name the missing ground-truth column in Sklearn Prediction's error #8918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kz930 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(workflow-operator): name the missing ground-truth column in Sklearn Prediction's error #8918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...tor/src/main/scala/org/apache/texera/amber/operator/sklearn/SklearnPredictionOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,11 @@ class SklearnPredictionOpDesc extends PythonOperatorDescriptor with StandaloneCo
var resultType = AttributeType.STRING
val inputSchema = inputSchemas(operatorInfo.inputPorts(1).id)
if (groundTruthAttribute != "") {
resultType =
inputSchema.attributes.find(attr => attr.getName == groundTruthAttribute).get.getType
if (!inputSchema.containsAttribute(groundTruthAttribute))

@carloea2 carloea2 Oct 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the exact-case lookup here. With input column label and configured name Label, schema validation now succeeds because containsAttribute ignores case. The generated script then fails at in2df.drop("Label", axis=1) with KeyError. I reproduced this with the generated code; label passes as a control. The native Python filter also compares names exactly.

throw new RuntimeException(
s"Ground Truth column '$groundTruthAttribute' is not in the input table"
)
resultType = inputSchema.getAttribute(groundTruthAttribute).getType
}
Map(
operatorInfo.outputPorts.head.id -> inputSchema
Expand Down
5 changes: 3 additions & 2 deletions ...src/test/scala/org/apache/texera/amber/operator/sklearn/SklearnPredictionOpDescSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,15 @@ class SklearnPredictionOpDescSpec extends AnyFlatSpec with Matchers {
.getType shouldBe AttributeType.INTEGER
}

it should "throw when the configured ground-truth attribute is absent from the input schema" in {
it should "name the configured ground-truth attribute when it is absent from the input schema" in {
val d = new SklearnPredictionOpDesc
d.resultAttribute = "prediction"
d.groundTruthAttribute = "missing"
val data = Schema().add("feature", AttributeType.STRING)
intercept[NoSuchElementException] {
val e = intercept[RuntimeException] {
d.getOutputSchemas(Map(PortIdentity(1) -> data))
}
e.getMessage shouldBe "Ground Truth column 'missing' is not in the input table"
}

"SklearnPredictionOpDesc.generatePythonCode" should "emit the model-applying tuple operator" in {
Expand Down
Loading