Repository navigation
refactor(frontend): remove dead pve-modal selectors - #8926
Open
aglinxinyuan wants to merge 1 commit into
Open
aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
No element has ever carried .subtitle under .system-header, and apache#4902 renamed the .package-inputs element to system-package-inputs. Drop the .subtitle rule and the bare .package-inputs token; .package-header-row and its rule stay.
Contributor
Automated Reviewer SuggestionsBased on the
|
github-actions
Bot
added
refactor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8926 +/- ##
=========================================
Coverage 92.59% 92.59%
Complexity 5040 5040
=========================================
Files 1252 1252
Lines 53587 53587
Branches 6673 6673
=========================================
+ Hits 49619 49620 +1
Misses 2317 2317
+ Partials 1651 1650 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Removes two selectors from the global stylesheet's Python-environment modal (
.pve-modal) block that match no element. +1/−8 lines. There is no behaviour change..pve-modal .system-header .subtitlerule. The only.system-headerelement (in the computing-unit selection modal) contains just a.title. No template, TS code or ng-zorro component produces a baresubtitleclass..package-inputstoken in.package-header-row, .package-inputs. The rule and.package-header-rowstay. The templates usesystem-package-inputsanduser-package-inputs, and CSS matches whole class tokens, so neither matches.package-inputs.Because these are global styles, the check covered every template and TS file in the app, plus ng-zorro's compiled output.
History
.pve-modalblocksystem-package-inputs, which left.package-inputsunmatched..subtitlewas never used.package-inputshas been dead for nearly five months.Any related issues, documentation, discussions?
Closes #8925
How was this PR tested?
No new tests; no spec referenced either selector.
From
frontend/:npx ng test --watch=false --include='**/user-venv.component.spec.ts' --include='**/computing-unit-selection.component.spec.ts': 2 files, 242 tests, all pass. These are the only specs that render the modal.yarn format:ci: clean.npx ng build: success.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code