tests: give cripts ATS startup a longer readiness window#13304
Open
moonchen wants to merge 1 commit into
Open
Conversation
Cripts are compiled at ATS startup, which under CI load can exceed the default 10s process-readiness timeout. Cripts gold tests then flake with "Process failed to become ready in time" before any request runs. Bump StartupTimeout to 60s for cripts-enabled ATS processes so the compile step has headroom. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts AuTest’s ATS process startup readiness window for Cripts-enabled gold tests to reduce intermittent CI failures caused by Cripts’ compile-at-startup overhead.
Changes:
- Increase
MakeATSProcess()startup timeout to 60 seconds whenenable_cripts=True. - Add an inline comment explaining why Cripts needs a longer readiness window.
Contributor
|
[approve ci autest 2] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
criptsautest (tests/gold_tests/cripts/cripts.test.py) intermittently fails in CI with:ATS never opens its port in time, so the subsequent runs cascade to connection-refused (
curl: (7)). It's not deterministic — the same commit passes on a faster worker — which makes it a flaky-CI nuisance unrelated to whatever PR happens to run it.Cause
Cripts plugins are compiled at ATS startup (via
proxy.config.plugin.compiler_path). Under CI load that compile can take longer than autest's default 10s process-readiness window (the wait forNOTE: Traffic Server is fully initialized), so the readiness check times out before ATS finishes coming up.Fix
Bump
StartupTimeoutto 60s for cripts-enabled ATS processes inMakeATSProcess, so the compile-at-startup step has headroom. This is scoped to theenable_criptsbranch, so only cripts tests are affected, and it follows the existing precedent of slow-startup tests settingts.StartupTimeout(e.g.jsonrpc/config_reload_*use 30).