[AliRana30]

Summary of Changes

• Configurable ID Encoding: Replaced the hardcoded final boolean encodeIds = false; in TreeEncoder with wayang.ml.encoding.encode-ids (defaulting to false, with shorthand wayang.ml.encode-ids supported).
• TreeEncoder Enhancements: Added TreeEncoder(mappings, configuration) constructor, getter/setter for configuration, and overloaded encode methods that resolve encodeIds from OptimizationContext or local configuration.
• Default Properties: Loaded wayang-ml-defaults.properties in MachineLearning.plugin().setProperties(Configuration) and declared wayang.ml.encoding.encode-ids = false.
• Unit Tests: Added test cases in TreeEncoderTest verifying default behavior, enabled ID encoding via configuration, and plugin properties loading.

Closes #776.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[AliRana30]

@zkaoudi Needed your review here.

[novatechflow]

Thanks, two issues:

• Loading the defaults during plugin registration overwrites user configuration, including encode-ids=true, the model path, experience collection, and reoptimization settings.
• The shorthand wayang.ml.encode-ids=true is ignored after registration because the default canonical property is always present as false.

Reproduced both with focused Java 17 checks. Always preserve user settings, fix shorthand resolution, and add regression tests covering plugin registration.

[AliRana30]

Thanks for the review @novatechflow ! Both issues are fixed and tested on Java 17:

1. User settings preserved: MachineLearning.setProperties now applies a default only if the user hasn't already set it. This covers encode-ids, the model path, experience collection and reoptimization.
2. Shorthand fixed: wayang.ml.encode-ids=true is no longer shadowed by the default canonical false.
3. Tests: Added regression tests in TreeEncoderTest for plugin registration and shorthand resolution.

[novatechflow]

The original issues are fixed and covered by regression tests, great progress!

One edge remains: a job-level false cannot override an inherited true when the canonical and shorthand properties differ.

Reproduced on Java 17. Please add parent/child override tests.

[AliRana30]

@novatechflow all your requirements have been added. A job-level false now overrides an inherited true in either direction. Resolution picks the nearest configuration level that sets either spelling, and the plugin no longer injects an encode-ids default that could shadow it. Added parent/child override tests, including 3-level chains and plugin registration.