Repository navigation
Conversation
Contributor
Author
|
@zkaoudi Pr is up for your review. |
Member
|
Thanks for the fix. Three issues to address before merging:
Reproduced all three on Java 17. Please tighten the allowlist and add regression tests. |
AliRana30
force-pushed
the
fix/object-input-filter-835
branch
from
October 21, 2026 23:02
05351a2 to
c2850f7
Compare
Contributor
Author
|
@novatechflow Updated the allowlist and WayangValue as per the feedback. Alos added regression tests for all three cases in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes?
ObjectFileSerialization:createObjectInputFilter(Class<?> elementType)to restrict legacy object deserialization to expected primitives, wrappers, standard safe collections, Wayang types, Scala tuples, and expectedelementTypehierarchies.wayang.basic.serialization.allowlist.InvalidClassException.WayangValue:ObjectInputFilteron Flink criterion deserialization.convertToByteandconvertToObjectto use try-with-resources.elementTypeacceptance, and system property pattern matching.Why are the changes needed?
Directly calling
ObjectInputStream.readObject()without anObjectInputFilterallows arbitrary class instantiation, posing a deserialization security risk (CWE-502).How was this tested?
ObjectFileSerializationTestandWayangValueTest.mvn testonwayang-basicandwayang-flink.mvn apache-rat:check.Closes : #835