Repository navigation
Conversation
Contributor
Author
|
@zkaoudi PR is up for your review. |
Member
|
Thanks for the contribution. Pls always add regression tests.
Reproduced both with focused Java 17 checks. Preserve identifier lookup semantics & handle dialect-specific names. |
AliRana30
force-pushed
the
fix/validate-escape-table-identifiers-836
branch
from
October 21, 2026 22:39
908cf6c to
76fecd5
Compare
Contributor
Author
|
@novatechflow I have addressed both issues and added regression tests covering both case folding and BigQuery formats. Verified on Java 17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes
wayang-basicto strictly validate single-part and multipart table/column identifiers using regex patterns (^[a-zA-Z_][a-zA-Z0-9_$]*(?:\.[a-zA-Z_][a-zA-Z0-9_$]*)*$) and escape/quote identifiers according to database dialect.IllegalArgumentException.DROP TABLE IF EXISTS,CREATE TABLE ... AS, andINSERT INTOclauses. Multipart identifiers (such as Trinocatalog.schema.table) are quoted segment-by-segment ("catalog"."schema"."table").SqlIdentifierUtilsfor safe identifier quoting.SqlIdentifierUtilsTestand updatedJdbcTableSinkExecutorTestto assert proper quoting and rejection of SQL injection payloads.Fixes : #836.
Verification
SqlIdentifierUtilsTest(10 tests passed)JdbcTableSinkExecutorTest(8 tests passed)JavaTableSinkTest(7 tests passed)SparkTableSinkTest(10 tests passed)apache-rat:check(0 unapproved licenses)