Repository navigation
Fix documentation parent version and validate it before merge - #846
Merged
Merged
Conversation
Contributor
|
the jobs are queued for so long time.. I restarted the workflow but it still takes so long.. Will check again in the evening |
zkaoudi
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation job fails to resolve its parent because wayang-docs still declares 1.1.1-SNAPSHOT while the root is 1.1.2-SNAPSHOT. The normal backend build excludes this profile, and the documentation workflow runs after push/PR closure, so the mismatch escaped pre-merge checks.
Align the documentation parent with the root version. Add a backend CI step that checks the versions directly (so a cached old parent cannot hide drift) and runs Maven validation with the web-documentation profile.
Validation: Java 17
./mvnw validate -B -Pweb-documentation -pl wayang-docspasses. The exact workflow version guard passes the corrected POM and rejects the original 1.1.1-SNAPSHOT parent.git diff --checkpasses. Full Jekyll generation and site publication were not run.Failure: https://github.com/apache/wayang/actions/runs/39558222015/job/119082962767