replace invalid xml chars in element content in OptimizedForSpeedSaver#74
Open
aizu-m wants to merge 1 commit into
Open
replace invalid xml chars in element content in OptimizedForSpeedSaver#74aizu-m wants to merge 1 commit into
aizu-m wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-tripping an element whose text holds an invalid XML character through the speed saver:
Traced it to OptimizedForSpeedSaver.entitizeAndWriteText. It special-cases '<', '&' and the '>' that closes ']]>', but never runs isBadChar, so a C0 control (or U+FFFE/U+FFFF) in element content is written out untouched and the result will not reparse. The default TextSaver.entitizeContent substitutes '?' for those characters, and this saver's own comment and pi emitters already do the same. The content path was the only emitter that skipped it.
Reachable from save(Writer, XmlOptions)/xmlText with setSaveOptimizeForSpeed(true) on content set via XmlCursor.insertChars. Fixed it the way the sibling pi emitter does: swap a bad char for '?' before the switch. Test added.