Repository navigation
Conversation
|
@m4p: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Contributor
|
We do not accept PRs directly to the 'apollo-ios-codegen' repo. All development is done through the 'apollo-ios-dev' repo, please see the CONTRIBUTING guide for more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I noticed that code generation triggers a swift compiler bug when used in a
AsyncParsableCommand. I have identified the issue and provided a workaround. See link and attached crash log for details about the triggered bug. I have verified this fixes the issue by using a fork in my toolchain.crashlog.txt
How
As the issue is triggered by stack management of
async lets, serializing the work vialet … = awaitworks around the issue.