Skip to content

feat: register the swipe routes on watchOS #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThiagoLannes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: register the swipe routes on watchOS #1257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion WebDriverAgentLib/Commands/FBElementCommands.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ + (NSArray *)routes
[[FBRoute GET:@"/element/:uuid/attribute/focused"] respondWithTarget:self action:@selector(handleGetFocused:)],
[[FBRoute POST:@"/wda/element/:uuid/focuse"] respondWithTarget:self action:@selector(handleFocuse:)],
#elif !TARGET_OS_WATCH
// Gesture synthesis isn't supported on watchOS - only /element/:uuid/click is available.
// Gesture synthesis isn't supported on watchOS; the routes below all rely on it. Swipe is
// the exception and is registered for watchOS separately, at the end of this list.
[[FBRoute POST:@"/wda/element/:uuid/swipe"] respondWithTarget:self action:@selector(handleSwipe:)],
[[FBRoute POST:@"/wda/swipe"] respondWithTarget:self action:@selector(handleSwipe:)],

Expand Down Expand Up @@ -116,6 +117,13 @@ + (NSArray *)routes
[[FBRoute POST:@"/wda/tap"] respondWithTarget:self action:@selector(handleTap:)],

[[FBRoute POST:@"/wda/pickerwheel/:uuid/select"] respondWithTarget:self action:@selector(handleWheelSelect:)],
#endif
#if TARGET_OS_WATCH
// Swiping does not need gesture synthesis: XCUIElement declares swipeUp/Down/Left/Right on
// watchOS, and -fb_swipeWithDirection:velocity: calls them directly. handleSwipe: is already
// compiled here (it lives in the non-tvOS branch below), so only the route was missing.
[[FBRoute POST:@"/wda/element/:uuid/swipe"] respondWithTarget:self action:@selector(handleSwipe:)],
[[FBRoute POST:@"/wda/swipe"] respondWithTarget:self action:@selector(handleSwipe:)],
#endif
[[FBRoute POST:@"/wda/keys"] respondWithTarget:self action:@selector(handleKeys:)],
];
Expand Down
Loading