Skip to content

Update constant name value to result in FirstNonNil for clarity - #286

Open
nkpgardose wants to merge 1 commit into
apple:mainfrom
nkpgardose:update-first-non-nil-tests
Open

nkpgardose wants to merge 1 commit into
apple:mainfrom
nkpgardose:update-first-non-nil-tests

Conversation

@nkpgardose

Copy link
Copy Markdown

Hi Apple team, I am currently learning Swift and I am checking how things implemented on some Swift projects.

I made a very small change here, renaming value to result to give more clarity.

Thanks and have a good day.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@nkpgardose nkpgardose changed the title Update variable name value to result in FirstNonNil for clarity Update constant name value to result in FirstNonNil for clarity Aug 31, 2026

@wallawonka wallawonka left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@wallawonka

Copy link
Copy Markdown

Any updates on making the Checklist fully checked? @nkpgardose

@nkpgardose

nkpgardose commented Oct 13, 2026 •

Copy link
Copy Markdown
Author

Hi @wallawonka! 👋 seems I can't merge it to the main branch. image

Hmm. Not sure what would be the next step

@nkpgardose

Copy link
Copy Markdown
Author

I can check all the items pn the list. My code change is super small. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants