fix(APP-1113): Filter out plugins flagged by the backend as unsupported - #1349
Merged
milosh86 merged 5 commits intoSep 2, 2026
Merged
Conversation
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
milosh86
deleted the
app-1113-pwn-dao-proposals-fail-to-load-in-production
branch
September 2, 2026 08:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PWN DAO proposals failed to load in production because one of its plugins was not installed through the standard OSx flow. The backend resolves an interface type for such a plugin, so the app accepted it as a governance target and then failed when loading proposals for it.
The backend now exposes an explicit
isSupportedflag on the plugin resource. This PR:isSupportedfield toIDaoPlugin.daoUtils.isSupportedPluginto also reject plugins withisSupported === false, sogetDaoPluginsfilters them out unlessincludeUnsupportedis passed (permissions and contract-versions views keep seeing them, as intended for on-chain inventory surfaces).The predicate stays a check on backend fields rather than a plugin-registry lookup — the registry is populated on demand, so a registry check would report every plugin as unsupported during server rendering. The existing JSDoc was updated to cover the new field.
Closes APP-1113.
Type of Change
Developer Checklist:
Review Checklist: