Skip to content

fix(APP-1113): Filter out plugins flagged by the backend as unsupported - #1349

Merged
milosh86 merged 5 commits into
mainfrom
app-1113-pwn-dao-proposals-fail-to-load-in-production
Sep 2, 2026
Merged

fix(APP-1113): Filter out plugins flagged by the backend as unsupported#1349
milosh86 merged 5 commits into
mainfrom
app-1113-pwn-dao-proposals-fail-to-load-in-production

Conversation

@milosh86

Copy link
Copy Markdown
Contributor

Description

PWN DAO proposals failed to load in production because one of its plugins was not installed through the standard OSx flow. The backend resolves an interface type for such a plugin, so the app accepted it as a governance target and then failed when loading proposals for it.

The backend now exposes an explicit isSupported flag on the plugin resource. This PR:

  • Adds the optional isSupported field to IDaoPlugin.
  • Extends daoUtils.isSupportedPlugin to also reject plugins with isSupported === false, so getDaoPlugins filters them out unless includeUnsupported is passed (permissions and contract-versions views keep seeing them, as intended for on-chain inventory surfaces).

The predicate stays a check on backend fields rather than a plugin-registry lookup — the registry is populated on demand, so a registry check would report every plugin as unsupported during server rendering. The existing JSDoc was updated to cover the new field.

Closes APP-1113.

Type of Change

  • Patch: Bug fix (non-breaking change which fixes an issue)

Developer Checklist:

  • Manually smoke tested the functionality in a preview or locally
  • Confirmed there are no new warnings or errors in the browser console
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the Files Changed in Github’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • Confirmed that changes follow the code style guidelines of this project

Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
@linear-code

linear-code Bot commented Aug 31, 2026

Copy link
Copy Markdown

APP-1113

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

🚀 Preview Deployment: View Here

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

E2E results (preview)

Smoke

Base URL https://app-next-qk8d911jr-aragon-app.vercel.app
Suite smoke
Playwright result ✅ passed
Summary 82 passed
HTML report View report
GitHub job ✅ completed

View run #5086

Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
milosh86 marked this pull request as ready for review August 31, 2026 11:41
@milosh86
milosh86 requested a review from a team as a code owner August 31, 2026 11:41

@thekidnamedkd thekidnamedkd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦔

@milosh86
milosh86 merged commit 11b6722 into main Sep 2, 2026
20 checks passed
@milosh86
milosh86 deleted the app-1113-pwn-dao-proposals-fail-to-load-in-production branch September 2, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants