feat(APP-1004): address the assistant design feedback round 2 - #1350
Open
tyhonchik wants to merge 1 commit into
Open
feat(APP-1004): address the assistant design feedback round 2#1350tyhonchik wants to merge 1 commit into
tyhonchik wants to merge 1 commit into
Conversation
The header and composer controls (new chat, collapse, back, add attachment) become gov-ui-kit buttons and drop their tooltips, the "Email support" escape hatch follows the app's plain link style — no underline, an external-link icon, opening in a new tab — and typing in a fresh chat no longer bounces the layout: the suggestion chips retire through visibility instead of unmounting. The ticket card gains a bottom margin so text following it in the same message no longer sits against its edge. Nothing links to Linear anymore: the createLinearTicket tool output drops the issue URL at the contract level — users have no access to the workspace, and anything in the output also reaches the model, which would narrate the link into the chat. The success card and the past-requests view quote the ticket reference instead; stored tickets and history entries from before the change still parse, the stale field is stripped.
tyhonchik
force-pushed
the
app-1004-ai-assistant-iteration-based-on-feedback-v2
branch
from
August 31, 2026 12:39
cb8466f to
37fc879
Compare
|
E2E results (preview) Smoke
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses Evan's second feedback round on the support assistant (APP-1004, comment). Previously the panel's icon controls were bespoke tooltip buttons, the email escape hatch was an underlined in-tab link, typing the first character of a fresh chat bounced the welcome layout, and the created-ticket card linked out to Linear. Now every control is a gov-ui-kit button, the link follows the app's plain link style in a new tab, the layout holds still, and nothing in the chat references Linear URLs — the ticket travels as a reference, not a link.
Changes
createTicketToolOutputSchemadropsurlat the contract level: users have no access to the workspace, and anything in the tool output also reaches the model, which would narrate the link into the chat. The service (createLinearTicket,linearGateway,sessionStore), the success card and the past-requests view now carry only the ticketidentifier, rendered as aTag. Stored tickets and localStorage history entries from before the change still parse — the stale field is stripped, not rejected.Button(tertiary/sm, icon-only) and lose their tooltips — the accessible name moves toaria-label. The send/stop controls keep their bespoke shape (no matchingIconTypefor the arrow/square glyphs).LINK_EXTERNALicon,target="_blank"— clicking it no longer risks navigating the app tab. Styled after the gov-ui-kitLinkrather than using it: its smallest type scale is too large for the caption line under the composer.visibilitywith their height kept.mt-3only, so assistant text following it in the same message sat against its border; it now carries symmetricmy-3withfirst:mt-0 last:mb-0.Note
Point 1 of the feedback (header not lined up with the navbar) is already fixed on
mainby #1303, which merged after the comment was written — measured live with Playwright on a DAO page: both bottom borders sit at exactly 91px. No change here.The PR spans both release scopes, so it carries two changesets:
@aragon/assistant-chatminor +@aragon/apppatch, and@aragon/assistantpatch +@aragon/assistant-contractsminor. Until the assistant service redeploys it keeps sendingurlin the tool output — the widget ignores the extra field, so the two can ship in either order.🤖 Generated with Claude Code