fix(APP-1126): show missing metadata warning only when title and description are both missing - #1357
Merged
Merged
Conversation
…ription are both missing
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrow, aligns with the described bug/acceptance criteria, and is covered by updated unit/component tests.
Pull request overview
Adjusts governance proposal “missing metadata” detection so the warning is only shown when both title and description are absent, preventing false warnings when the description is available and rendered.
Changes:
- Update
proposalUtils.getMetadataStatusto treat metadata asSTANDARDwhen eithertitleordescriptionis present. - Extend/adjust unit tests for
getMetadataStatusto cover “description-only” metadata. - Update component tests to ensure the warning expectations reflect the new “title + description both missing” rule.
File summaries
| File | Description |
|---|---|
| apps/app/src/modules/governance/utils/proposalUtils/proposalUtils.ts | Changes metadata status logic to consider description presence (not just title). |
| apps/app/src/modules/governance/utils/proposalUtils/proposalUtils.test.ts | Updates/extends util tests for the revised metadata rule. |
| apps/app/src/modules/governance/pages/daoProposalDetailsPage/daoProposalDetailsPageClient.test.tsx | Adjusts details page tests to align warning behavior with the updated status logic. |
| apps/app/src/modules/governance/components/daoProposalList/daoProposalListDefaultItem.test.tsx | Adjusts list item tests to align warning behavior with the updated status logic. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The missing metadata warning was shown whenever the proposal title is null, even when the description resolved fine and is rendered right below the alert.
getMetadataStatusnow treats the metadata as standard when either title or description is set, so the warning only shows when both are missing. Updated the util and component tests for the new rule.Linear: https://linear.app/aragon/issue/APP-1126/missing-metadata-warning-shows-even-when-the-content-is-there
Type of Change
Developer Checklist:
Review Checklist: