Repository navigation
vicinity: remove unsafe from SIMD and benchmark targets - #20
Merged
Merged
Conversation
added 7 commits
October 11, 2026 15:44
Forbid unsafe code in the crate, preserve four independent ADC accumulators, and use capability-token intrinsics for FastScan. Strengthen the lane-order oracle and remove unverified timing equivalence. Native, portable, feature-matrix, MSRV, integration, clippy and documentation gates pass. Delivery remains held for a published pulp replacement without unmaintained paste and clean performance measurements.
arclabs561
marked this pull request as ready for review
October 26, 2026 00:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace locally authored unsafe PQ/NEON kernels and benchmark allocator wrappers, and enforce
forbid(unsafe_code)across targets. Safe stats_alloc instrumentation retains process-wide diagnostics; acquired bytes count allocations plus positive realloc growth.This development branch pins Pulp to
601de0c071ba32df3fd7ff33fc4218c9bd712abaand Innr to392736772688262ce5f89f51db6b08a8167b8262. A root Innr override makes Qntz and benchmark dependencies exercise that same safe port. Rust 1.94 is required by the pinned x86 backend; CI and docs match. The LID example uses the standard golden-ratio constant with identical f32 bits.Local QA, all-feature check, strict all-target Clippy, docs, benchmark compilation and matched Rust 1.94 ARM/x86 library checks pass. The full library suite passed 614 tests with 5 existing measurement skips on the preceding snapshot; the final executable delta is a bit-identical example constant. Final exact-head CI 39844248983 passes all 13 jobs, including Python, semver, feature coverage, regressions, ARM, x86, MSRV and ANN quality/smoke checks.
Keep this draft: Git dependencies still gate registry publication. This root patch validates development composition; dependency internals retain unsafe and unrelated paste remains through Simba.