Repository navigation
spec: define 'align' for publisher authority binding (§4.5.1) #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sachinsharma3191
wants to merge
1
commit into
ards-project:main
Choose a base branch
from
sachinsharma3191:fix/94-define-align
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together, @sachinsharma3191
One concern with allowing any subdomain to match by default: in many deployments, subdomains (dev.acme.com, staging.acme.com, vendor-hosted subdomains, or multi-tenant hosts) are operated at a lower trust level than the apex domain. If spiffe://dev.acme.com/... or did:web:dev.acme.com automatically aligns with urn:air:acme.com:..., a lower-trust subdomain can mint entries under the root acme.com namespace without acme.com's authorization.
It would be safer (and simpler) to require an exact domain match between the trust domain and (both as lowercase ASCII A-labels, since §4.2 already requires to be lowercase. If prod.acme.com is its own trust domain, it can either publish as urn:air:prod.acme.com:... or be explicitly delegated by acme.com at the key/DID/bundle layer. That also avoids needing verifiers to bundle and maintain a Public Suffix List just to guard subdomain matching.