Repository navigation
Backport[IMPALA-14466]: Remote client should not cache admissiond's IP when retrying AdmitQuery RPC - #16
Open
giggsoff wants to merge 1 commit into
Open
Backport[IMPALA-14466]: Remote client should not cache admissiond's IP when retrying AdmitQuery RPC#16giggsoff wants to merge 1 commit into
giggsoff wants to merge 1 commit into
Conversation
…rying AdmitQuery RPC The remote admission client's retry logic for AdmitQuery RPC did not handle cases where the admissiond restarts with a new IP address. The client would use the old proxy and retry against the old, stale ip, causing queries to time out. This change fixes the issue by adding the GetProxy() call inside the retry loop. This forces the client to re-resolve the admissiond's network address on each retry attempt, allowing it to discover the new endpoint and successfully reconnect. Tests: Passed admissiond related exhaustive ee tests. Since automatically change hosts might be difficult, manually test to change the /etc/hosts with following steps: 1. Start with --admission_service_host=localhost. 2. Change the 'localhost' in /etc/hosts to an inaccessible IP, like 127.0.0.2. 3. Submit a query, it will block in the retry logic. 4. While the query is blocked, change 'localhost' in /etc/hosts back to 127.0.0.1. 5. The query succeeded. Change-Id: I5857de84ce69902b902099f668e87d747f944aff Reviewed-on: http://gerrit.cloudera.org:8080/23472 Reviewed-by: Abhishek Rawat <arawat@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> (cherry picked from commit 63dee74)
giggsoff
force-pushed
the
hotfix/NGSOK-2204
branch
from
September 29, 2026 13:58
a7d7ce7 to
8436d1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote admission client's retry logic for AdmitQuery RPC did not handle cases where the admissiond restarts with a new IP address. The client would use the old proxy and retry against the old, stale ip, causing queries to time out.
This change fixes the issue by adding the GetProxy() call inside the retry loop. This forces the client to re-resolve the admissiond's network address on each retry attempt, allowing it to discover the new endpoint and successfully reconnect.