Repository navigation
Conversation
…ervice ### What changes were proposed in this pull request? This PR aims to add `Spark Connect` port to `Spark Driver` pod and service. ### Why are the changes needed? To support `Spark Connect` easily. ### Does this PR introduce _any_ user-facing change? No behavior change because this is a new port. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#50925 from dongjoon-hyun/SPARK-52193. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit c8327c5)
### What changes were proposed in this pull request? Set `appProtocol` to `"grpc"` on the `spark-connect` service port in `DriverServiceFeatureStep`. ### Why are the changes needed? Without `appProtocol: grpc`, service meshes (e.g. Istio, Linkerd) treat gRPC traffic as opaque TCP. This prevents L7-aware load balancing, protocol-specific retries, and proper gRPC health checking for Spark Connect sessions. This change is limited to the `spark-connect` port because gRPC is unambiguous regardless of SSL configuration. Other ports (HTTP-based) are left untouched since their protocol depends on `spark.ssl.*` settings. ### Does this PR introduce _any_ user-facing change? No. The `appProtocol` field is advisory and has no effect in environments without a service mesh. ### How was this patch tested? Updated `DriverServiceFeatureStepSuite.verifyService()` to assert that the `spark-connect` port has `appProtocol: "grpc"`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.6 Closes apache#55148 from j1wonpark/SPARK-56275-spark-connect-appProtocol. Authored-by: Jiwon Park <jpark92@outlook.kr> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 99abe2c)
…inio It seems `minio/minio:RELEASE.2025-09-07T16-13-09Z` has gone. I just searched on Docker Hub and pick one that looks reliable as the replacement https://hub.docker.com/r/alpine/minio Recover K8s IT. No. Wait for CI. No. Closes apache#58764 from pan3793/minio-image. Authored-by: Cheng Pan <pan3793@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 1f1c57e)
giggsoff
marked this pull request as ready for review
October 9, 2026 07:28
giggsoff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport spark-connect port to 3.5