Skip to content

fix(deploy-tests): preserve API refusal details - #395

Merged
k-taro56 merged 1 commit into
mainfrom
fix/deploy-test-api-errors-20261029
Oct 29, 2026
Merged

k-taro56 merged 1 commit into
mainfrom
fix/deploy-test-api-errors-20261029

Conversation

@soleil-colza

@soleil-colza soleil-colza commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

When a deployment API request fails, the test client currently reports only the HTTP status and error code, hiding the reason the host returned. Include the API message in a single log line capped at 2,048 characters, redact authentication tokens and known secret environment values, and preserve the existing malformed-response fallback and retry decisions. Keep the original API error as the cause of the friendly unsupported-Next.js explanation.

Validation: 16 focused fetch-stub tests passed; ESLint and formatting checks passed for the changed files. No live deployment tests or benchmarks were run.


Summary by cubic

When a deployment API request fails, the test client now reports the host's reason in the error message instead of only the HTTP status and error code. The message stays a single log line capped at 2,048 characters, with authentication tokens and known secret environment values redacted. Malformed-response handling and retry decisions are unchanged, and the original API error is preserved as the cause of the friendly unsupported-Next.js explanation.

  • refusalOf now reads the message field from the API error body and includes it in the ApiError message.
  • Secret values are collected from the auth token and from environment entries (both sent and fetched) before the message is normalized and redacted.
  • The unsupported-Next.js explanation in deploy.ts now chains the underlying API error as its cause.

Written for commit edcb2f1. Summary will update on new commits.

View guided diff Turn on auto-fix

@arkor-deploy

arkor-deploy Bot commented Oct 29, 2026

Copy link
Copy Markdown

Arkor — Preview deployments for arkorlab-upwind

Use the checkbox below to choose whether this pull request gets preview deployments.

  • Build and deploy previews for this pull request

Checking this builds the latest commit and future pushes. Unchecking stops queued and future builds; a running build can finish and an existing preview stays available.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 29da0c0b-2353-4431-8b0a-e7f27f5e8099
Commits

Reviewing files that changed from the base of the PR and between 4410822 and edcb2f1.

Files selected for processing: 3
  • tools/deploy-tests/src/client.ts
  • tools/deploy-tests/src/deploy.ts
  • tools/deploy-tests/test/client.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T14:45:09.449614Z edcb2f1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

API refusals now include the host’s reason alongside the HTTP status and code.

  • Deployment API refusals now show the host's reason in a safe, bounded line.
  • Unsupported Next.js explanations keep the original API refusal attached.

No actionable issues were found. No tests were run during this review.

Reviews (1) · Last reviewed commit: "fix(deploy-tests): preserve API refusal ..." · Reviewed by Greptile

@k-taro56
k-taro56 merged commit 32f3465 into main Oct 29, 2026
49 checks passed
@k-taro56
k-taro56 deleted the fix/deploy-test-api-errors-20261029 branch October 29, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants