Repository navigation
fix(deploy-tests): preserve API refusal details - #395
Conversation
|
Arkor — Preview deployments for arkorlab-upwind Use the checkbox below to choose whether this pull request gets preview deployments.
Checking this builds the latest commit and future pushes. Unchecking stops queued and future builds; a running build can finish and an existing preview stays available. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryAPI refusals now include the host’s reason alongside the HTTP status and code.
No actionable issues were found. No tests were run during this review. Reviews (1) · Last reviewed commit: "fix(deploy-tests): preserve API refusal ..." · Reviewed by Greptile |
When a deployment API request fails, the test client currently reports only the HTTP status and error code, hiding the reason the host returned. Include the API message in a single log line capped at 2,048 characters, redact authentication tokens and known secret environment values, and preserve the existing malformed-response fallback and retry decisions. Keep the original API error as the cause of the friendly unsupported-Next.js explanation.
Validation: 16 focused fetch-stub tests passed; ESLint and formatting checks passed for the changed files. No live deployment tests or benchmarks were run.
Summary by cubic
When a deployment API request fails, the test client now reports the host's reason in the error message instead of only the HTTP status and error code. The message stays a single log line capped at 2,048 characters, with authentication tokens and known secret environment values redacted. Malformed-response handling and retry decisions are unchanged, and the original API error is preserved as the cause of the friendly unsupported-Next.js explanation.
refusalOfnow reads themessagefield from the API error body and includes it in theApiErrormessage.deploy.tsnow chains the underlying API error as its cause.Written for commit edcb2f1. Summary will update on new commits.