Repository navigation
Expose the project configuration file loader - #396
soleil-colza wants to merge 3 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Arkor — Preview deployments for arkorlab-upwind Use the checkbox below to choose whether this pull request gets preview deployments.
Checking this builds the latest commit and future pushes. Unchecking stops queued and future builds; a running build can finish and an existing preview stays available. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Project config discovery and reading packages/adapter/src/project-config.ts, packages/adapter/test/project-config.test.ts, packages/adapter/README.md |
The adapter exports functions to find and read project configuration files. The reader returns the filename and unvalidated value, or an undefined filename and empty value when no file exists. Existing configuration loading uses the shared reader. Tests and documentation cover the API. |
Build and package exports packages/adapter/scripts/build.ts, packages/adapter/package.json |
The build creates separate index and project-config entries and logs each entry’s size. The package exports the project-config entry for source and published output. |
CommonJS metadata decoding
| Layer / File(s) | Summary |
|---|---|
Explicit UTF-8 decoding option packages/adapter/src/node-original-load-mode.ts |
The fatal UTF-8 decoder now sets ignoreBOM: false, matching its prior default. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Suggested reviewers: k-taro56
Merge Risk: 
Minimal · up to ce6a5
-
The documented build-tools API is ready to merge. Published TypeScript declarations remain a known limitation.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 5 functions across 4 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
[Medium impact] The PR appears safe to merge based on the changes since the previous review. SummaryExposes
Reviews (2) · Last reviewed commit: "Separate configuration test assertions f..." · Reviewed by Greptile |
Expose
findProjectConfigFileandreadProjectConfigFilethrough@stayingupwind/adapter/project-configso build tools can read the selected configuration without applying adapter-specific validation. The existing reader delegates to the same implementation, preserving file precedence, JSONC handling and executable TypeScript exports.Validation: all 37 project-configuration tests pass; the adapter package builds with the new published subpath.
Summary by cubic
Exposes
findProjectConfigFileandreadProjectConfigFilethrough the new@stayingupwind/adapter/project-configsubpath so build tools can read the selected config without adapter-specific validation. The adapter's existing reader now delegates to them, preserving file precedence, JSONC handling, and executable TypeScript exports. The build now emits the subpath as its own entry, and the packager's explicit BOM handling is kept portable. All 37 project-configuration tests pass, and the adapter package builds with the published subpath.Written for commit ce6a575. Summary will update on new commits.
Summary by CodeRabbit