Repository navigation
Migrate owned compiler tools to the TypeScript 7.1 API - #397
soleil-colza wants to merge 2 commits into
Conversation
|
Arkor — Preview deployments for arkorlab-upwind Use the checkbox below to choose whether this pull request gets preview deployments.
Checking this builds the latest commit and future pushes. Unchecking stops queued and future builds; a running build can finish and an existing preview stays available. |
Walkthrough
Merge Risk:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Low impact] The PR appears safe to merge; the follow-up preserves the compiler's lifetime and all helper calls. SummaryMoves the privacy test and handler-lifetime proof to the TypeScript 7.1 synchronous API.
Reviews (2) · Last reviewed commit: "Share the lifetime proof compiler withou..." · Reviewed by Greptile |
|
@codex review |
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@coderabbitai review |
✅ Action performed
|
The runtime-manifest privacy test and handler-lifetime harness still use the legacy compiler API. Move them to the TypeScript 7.1 Beta synchronous client and AST entry point, with explicit disposal of compiler processes and retained source files.
Add the native compiler under a development-only
typescript-apialias. Keep TypeScript 6 explicitly selected for package typechecking, the legacy VFS resolver proof, and lint compatibility. Production dependencies and request processing are unchanged.Validation:
git diff --checkpassed.Full gates run in CI. No benchmarks or deployed Cloudflare tests were run.
Reference: TypeScript 7.1 Beta API.
Review status:
unicorn/no-unnecessary-parametersin the handler-lifetime helpers. The helpers now capture the same single module-scoped compiler. Targeted ESLint, typecheck, the five-lane local proof, formatting and independent review passed after this correction.643e7f8a): all CI gates passed. Sentry and Greptile completed with no findings. Independent review of the final compiler-lifetime change found no issues.Summary by cubic
Migrates the runtime-manifest privacy test and handler-lifetime harness from the legacy TypeScript compiler API to the TypeScript 7.1 Beta synchronous client and AST entry point.
typescript-apialias; TypeScript 6 remains selected for package typechecking, legacy VFS proof, and lint.usingdeclarations.Written for commit 643e7f8. Summary will update on new commits.
Summary by CodeRabbit