Skip to content

fix(ci): run the deploy-tests shards on Node.js 24 #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k-taro56 merged 2 commits into from
Oct 30, 2026
Merged

fix(ci): run the deploy-tests shards on Node.js 24 #402

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f2190f
fix(ci): run the deploy-tests shards on Node.js 24
k-taro56 Oct 30, 2026
6338633
fix(ci): pin the deploy-tests shards to Node.js 24.22.1
k-taro56 Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/deploy-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,9 +385,15 @@ jobs:
ref: ${{ needs.plan.outputs.nextjs }}
path: nextjs
fetch-depth: 25
# Node.js 24, not the 26 this repository builds with: the suite runs out of Next.js's checkout, and
# its harness does not load on 26. `run-tests.js` requires `yargs/yargs`, an extensionless file in
# a `"type": "module"` package, which 26 reads as an ES module ("require is not defined in ES
# module scope"). This repository keeps Node.js 24 working, and every shard ran on it until 26.
# Exactly 24.22.1: the adapter builds a native Function only under the Node.js versions it
# guards (`isGuardedNodeVersion`), and a floating `24` would move past it.
- uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
with:
node-version: 26.13.0
node-version: 24.22.1
# Corepack rather than `pnpm/action-setup`, which reads one `packageManager` from where it runs:
# there are two checkouts here and no manifest above them, and they do not agree on a version.
# This way each directory's own `packageManager` is honoured — Next.js's inside `nextjs`, this
Expand Down
Loading