Repository navigation
Common: derive Hash.otp secrets from the app key - #19
Merged
Merged
Conversation
Hash.otp used one hardcoded TOTP secret for every label, so a code issued for one account was valid for all of them and anyone could compute it from the published package. Each label now gets its own secret, an HMAC of the label under APP_KEY.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hash.otp()built every code from one hardcoded TOTP secret (US3WHSG7X5KAPV27VANWKQHF3SH3HULL), and thelabelhad no effect on the result. Within a period, every label got the same code, and anyone could compute it from the published package. Apps that useHash.otpfor password reset, email verification or emailed 2FA codes were open to account takeover.Fix
Each label now gets its own secret: an HMAC-SHA256 of the label under
APP_KEY. The method signature is unchanged.Hash.otpthrows if no app key is configured.Upgrade note
Codes issued before the upgrade stop validating once it is deployed.
Tests
packages/common/tests/hash.test.tscovers:APP_KEY;