Repository navigation
Bump @arkstack to 0.20.1 (unique JWTs) - #6
Merged
Merged
Conversation
0.20.1 gives every JWT a unique jti. Two logins by the same user within one second produced identical tokens, which collided on the unique personal_access_tokens.token column and failed the login with a 500; this is what made admin-users.test.ts fail in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@arkstack/*to 0.20.1, which gives every JWT a randomjti(arkstack-hq/arkstack#18).Before, two logins by the same user within one second produced identical tokens. The second collided on the unique
personal_access_tokens.tokencolumn and the login failed with a 500. That is what failedadmin-users.test.tsin CI (register, then log in within the same second), and a double-submitted login in production hit the same 500.Tests
API suite passes locally (260 tests), and
admin-users.test.tspasses three runs in a row.