Skip to content

Fixes for twig 1.25 or greater #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bfgasparin wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes for twig 1.25 or greater #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7d138f
Fixed StackNodeVisitor for latest 1.* twig version
Oct 25, 2017
5402a2b
Fixed for twig 1.25
Oct 25, 2017
5914315
Changed the package name
Nov 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "aygon/twig-stack",
"name": "bfgasparin/twig-stack",
"type": "library",
"description": "Twig extension which adds the possibility to push content to a stack which can be output anywhere in the template",
"keywords": ["templating"],
Expand Down
4 changes: 2 additions & 2 deletions lib/TwigStack/NodeVisitor/StackNodeVisitor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public function leaveNode(\Twig_NodeInterface $node, \Twig_Environment $env)
*/
private function handleModuleNode(\Twig_Node_Module $node)
{
if ($node->hasNode('body') && null === $node->getNode('parent')) {
if ($node->hasNode('body') && (!$node->hasNode('parent') || null === $node->getNode('parent'))) {
$body = $node->getNode('body');
$node->setNode('body', new StackBodyNode($body));
}
Expand All @@ -70,4 +70,4 @@ public function getPriority()
{
return -10;
}
}
}