Repository navigation
feat!: remove ailoop integration and the ailoop-core dependency - #196
Merged
Merged
Conversation
The upstream goailoop/ailoop repository is no longer publicly fetchable, so every build resolving cli-framework failed on its mandatory ailoop-core git dependency. - Drop ailoop-core and src/ailoop; remove AppBuilder::with_ailoop_channel, with_ailoop_config, App::ailoop_client, ChatToolCallOptions::ailoop_client and ConfirmationMode::Ailoop. - RiskEnforcer::enforce_preflight loses its ailoop_available parameter: Sensitive proceeds when interactive or --yes; Destructive needs ALLOW_DESTRUCTIVE_COMMANDS and an interactive terminal. - Delete the with_ailoop example and the ailoop_websocket test. - Drop the cargo-audit ignores that existed only for ailoop-core's rustls-webpki 0.101 (#51). - Update README, CONTEXT, CONTRIBUTING, AGENTS and the skill (0.5.0). BREAKING CHANGE: the AppBuilder ailoop API and cli_framework::ailoop are removed; enforce_preflight takes three arguments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ULw7P2iqqymdGs7U3jpE7b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the ailoop integration and its mandatory
ailoop-coregit dependency.The upstream
goailoop/ailooprepository is no longer publicly fetchable, soany build that resolves cli-framework failed to fetch
ailoop-coreanonymously, even for consumers that never used it.
ailoop-corefromCargo.tomland deletesrc/ailoop.lib.rs,AppBuilder/App(with_ailoop_channel,with_ailoop_config,ailoop_client),DispatchEnv, thechatcommand andruntime,
McpHostToolAdapter, andConfirmationMode::Ailoopin the tool bridge.RiskEnforcer::enforce_preflightloses itsailoop_availableparameter.Sensitive proceeds when the terminal is interactive or
--yesis given;Destructive needs
ALLOW_DESTRUCTIVE_COMMANDS=1and an interactiveterminal.
PrefightErrordocs and theDestructiveNeedsInteractivemessageno longer mention ailoop.
with_ailoopexample and theailoop_websocketintegration test(and their
[[example]]/[[test]]entries).(
plugins-and-ailoop.mdbecomesplugins.md; skill version 0.4.0 → 0.5.0).ADRs are left as historical records.
.cargo/audit.toml: drop the RUSTSEC-2026-0098/0099/0104 ignores. Theyexisted only for the
rustls-webpki 0.101thatailoop-corepulled inthrough
reqwest 0.11(chore: bump aikit-sdk and ailoop-core to latest (fix legacy ailoop Question wire format) #51). After this change the lockfile resolvesrustls-webpki 0.103.16only.Release notes
Breaking: the
AppBuilderailoop API is removed (with_ailoop_channel,with_ailoop_config,App::ailoop_client, thecli_framework::ailoopmodule,
ChatToolCallOptions::ailoop_client,ConfirmationMode::Ailoop), andRiskEnforcer::enforce_preflighttakes three arguments instead of four. SeeCHANGELOG
[Unreleased].Test plan
cargo fmt --all -- --checkcargo clippy --all-features -- -D warningscargo test(default,chat,mcp-server,chat,mcp-server)cargo test --features telemetry,config,config-service,mcp-server,api-server,testkit,derive: all pass except twoconfig_backend_filepermission tests, which fail only because the local run was as root (permission bits are not enforced); that code is untouched herecargo build --examplescargo build --all-features --release: left to CIcargo tree -i ailoop-core --all-featuresfinds nothing;Cargo.lockhas noailoopentryFollow-up to #51: the advisory ignores it tracked are no longer needed.
Generated by Claude Code