Reject negative numbers in dehumanize()#1310
Open
eeshsaxena wants to merge 1 commit into
Open
Conversation
dehumanize() extracts numbers with an unsigned `\d+` pattern, and the
surrounding match anchors on a word boundary, so a minus sign attached
to a number (e.g. "in -1 hours") is silently discarded. The result was
a datetime in the opposite direction from what the string expressed:
"in -1 hours" produced the same value as "in 1 hours".
Humanized strings encode direction with words ("ago"/"in"), never with
an arithmetic sign, so humanize() never emits one. Reject any input
containing a negative number with a ValueError instead of returning a
quietly wrong result.
Fixes arrow-py#1278
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1310 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2317 +2
Branches 358 359 +1
=========================================
+ Hits 2315 2317 +2 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1278.
dehumanize()extracts numbers with an unsigned\d+pattern, and the surrounding match anchors on a word boundary, so a minus sign attached to a number (e.g."in -1 hours") is silently discarded. The result is a datetime in the opposite direction from what the string expressed.Before
After
Rationale
Humanized strings encode direction with words (
"ago"/"in"), never with an arithmetic sign, sohumanize()itself never emits one. A negative number in the input is therefore always malformed, and returning a quietly-wrong result is worse than raising. The guard rejects any-<digit>in the input; all existing positive/ago/in/nowinputs are unaffected.Tests
Added
test_negative_number(covers"in -1 hours","in -2 days","-3 minutes ago"). Full dehumanize suite passes (23 tests).