Add support for FISO2/U2F sk- key types - #56
Closed
nicolas-graves wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Disclaimer: I partly used gen AI to generate tests |
I noticed a few key types were missing, it's probably a good idea to add
them.
* libguile-ssh/key-type.c (key_types): Add missing key types sk-ecdsa,
sk-ecdsa-cert01, sk-ed25519, sk-ed25519-cert01.
* tests/keys/skecdsakey.pub: Add new test key.
* tests/keys/sked25519key.pub: Likewise.
* tests/Makefile.am (EXTRA_DIST): Record them.
* tests/common.scm (%skecdsakey-pub, %sked25519key-pub): Add them.
* tests/key.scm (unless-sk-supported): Add helper macro.
(%skecdsakey-pub-string, %sked25519-pub-string): Add helper variables.
("public-key-from-file: SK-ECDSA", "public-key-from-file: SK-ED25519")
("get-key-type: SK-ECDSA", "get-key-type: SK-ED25519")
("string->public-key, SK-ECDSA", "string->public-key, SK-ED25519"): Add tests.
* NEWS: Add a entry.
nicolas-graves
force-pushed
the
sk-keys
branch
from
August 11, 2026 18:08
f634de7 to
6f8fbb0
Compare
nicolas-graves
changed the title
Owner
|
Merged to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a few key types were missing, it's probably a good idea to add them.