Drop internal "phase" framing from the debugging docs - #111
Closed
assapir wants to merge 2 commits into
Closed
Conversation
The public CHANGELOG and LANGUAGE.md described --debug's scope as "Phase 1 / a later phase"; phase numbers are internal orchestration. Reword to state the capability and its current scope (line tables + per-function scopes; imported modules carry no line info yet) without the phase label. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Complete the de-phase: drop the "(Phase 1)" module-doc labels on src/codegen/debug.rs and tests/debug_info_test.rs, and reword two internal comments that framed remaining work as a "later phase" / "line-tables phase" to describe the state directly. `git grep -niE 'phase [0-9]'` is now empty repo-wide (the only remaining "phase" is the unrelated progress helper in scripts/release.sh). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Owner
Author
|
Superseded — phase-cleanup consolidated into the debug agent's cleanup PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the merged 0.9.1 release-prep (#103). #103 was merged at its tip
before the final de-phasing edit landed, so
mainstill describes--debug'sscope as "Phase 1 / a later phase" in
CHANGELOG.mdandLANGUAGE.md. Phasenumbers are internal orchestration and should not appear in the public docs.
This reword keeps all substance — what
--debugemits, the line-tables +per-function-scopes scope, and the imported-module known limitation — and only
removes the "phase" label/sentence. Docs-only; no code or behavior change.
Recommend merging before cutting
v0.9.1(via./scripts/release.sh) so therelease ships the de-phased wording.
🤖 Generated with Claude Code