Introduce Skeleton for PrimitiveIterable assertions#20
Open
mattbertolini wants to merge 10 commits into
Open
Conversation
…collections. This includes a test harness for primitive collections testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
AbstractPrimitiveIterableAssertclass and supporting implementation skeleton classes for the primitive collections. Eclipse Collections has a set of dedicated primitive collections that avoid boxing/unboxing of primitive types. Because of this, they can't share the same interfaces that the traditional collections use. This requires a whole new assertion hierarchy that is based on the basePrimitiveIterableinterface.I've started with implementing the size assertions in
AbstractPrimitiveIterableAssertand the contains assertion in each of the eight primitive type concrete assertion classes. There isn't a common interface I can link the contains method with in each class so I've created a JUnit parametrized test harness that will exercise each of the primitive types collections. This ensures that the method is consistent across types.I do expected this type hierarchy to change over time but I want to get the skeleton in place so I can iterate on it as more assertions are added.