Prove tlb flush functions - #677
Draft
DID-Lab-SZU wants to merge 3 commits into
Draft
Conversation
Marsman1996
requested changes
Jul 30, 2026
Marsman1996
left a comment
Marsman1996
left a comment
Collaborator
There was a problem hiding this comment.
I'm not sure, too many exec code modifications
Marsman1996
approved these changes
Jul 31, 2026
Marsman1996
left a comment
Marsman1996
left a comment
Collaborator
There was a problem hiding this comment.
From fa2a3b8 we can see that KVerus now still let the exec code modification passes without human review, which we shall think of a better method to guard the exec code...
Collaborator
|
This should be closed because:
@rikosellic I don't think this PR should be merged right now. Perhaps this is part of the phase III content? |
Collaborator
|
This will also interfere with page table designs because old mappings will likely need to reconcile with the latest modifications, for example. |
hiroki-chen
marked this pull request as draft
July 31, 2026 14:42
Collaborator
|
Yeah we should discuss this later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.