Repository navigation
Merge main into v2 - #2422
Merged
Merged
Merge main into v2#2422
Conversation
When the CLI detects a platform version below 1.0.0, create has no --cluster-id flag and reuses the app config fetched at startup. If that lookup failed, deployment.Create panicked on the nil config. Return errNoAppConfig instead, as v2 does. Co-authored-by: Sai Ram <4089996+vjsairam@users.noreply.github.com>
Coverage Report for CI Build 40010413077Coverage increased (+0.003%) to 60.682%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
main's one commit since #2416 intov2.cmd/apc/deployment_test.go(+14): v2 already had the sameerrNoAppConfigguard and message, from 8a5a4f1;TestDeploymentCreateCommandNoAppConfigis coverage v2 lackedChecks
git rev-list HEAD..origin/mainis 0.v2is the one test and nothing else.go test -race -shuffle=on ./cmd/apc/passes, the new test included (its--labelis v2's hidden 1.x alias for--name); golangci-lint v2.13.2 reports 0 issues oncmd/apc.