Repository navigation
Add named DAG bundle deploys - #167
Merged
Merged
Conversation
jeremybeard
added this pull request to stack #169
October 15, 2026 17:25
jeremybeard
force-pushed
the
named-dag-bundles
branch
from
October 15, 2026 19:03
b32ce50 to
289d1ca
Compare
jeremybeard
force-pushed
the
named-dag-bundles
branch
from
October 15, 2026 19:30
289d1ca to
98a5d3c
Compare
jeremybeard
force-pushed
the
named-dag-bundles
branch
2 times, most recently
from
October 16, 2026 18:06
b9a62b5 to
72cbbf3
Compare
jeremybeard
force-pushed
the
named-dag-bundles
branch
from
October 16, 2026 18:15
72cbbf3 to
99cf005
Compare
jeremybeard
force-pushed
the
named-dag-bundles
branch
from
October 16, 2026 18:40
99cf005 to
e017966
Compare
jeremybeard
marked this pull request as ready for review
October 16, 2026 19:11
wendtek
approved these changes
Oct 16, 2026
neel-astro
approved these changes
Oct 19, 2026
| DAGS_DIR=${dags_abs#"$PWD"} | ||
| DAGS_DIR=${DAGS_DIR#/} | ||
| fi | ||
| echo "DAGS_DIR=$DAGS_DIR" >> $GITHUB_OUTPUT |
Collaborator
There was a problem hiding this comment.
nit: CLI 1.44.x using dag path without a project fails during deploy rather than at validation level :)
Collaborator
Author
There was a problem hiding this comment.
I think this is an obscure enough scenario that we don't need to add logic for it to fail earlier.
| continue | ||
| fi | ||
| if [[ "${{ inputs.deploy-type }}" == "dbt" || "${{ inputs.deploy-type }}" == "non-dags" ]]; then | ||
| echo "ERROR: $option_name is only supported with deploy-type infer, dags-only, image-and-dags, or image-only" |
Collaborator
There was a problem hiding this comment.
Suggested change
| echo "ERROR: $option_name is only supported with deploy-type infer, dags-only, image-and-dags, or image-only" | |
| echo "ERROR: $option_name is only supported with deploy-type infer, dags-only or image-and-dags" |
nit: image-only not supported for these flags I guess
jeremybeard
force-pushed
the
named-dag-bundles
branch
from
October 19, 2026 13:19
e017966 to
c2a17a1
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
jeremybeard
force-pushed
the
named-dag-bundles
branch
from
October 19, 2026 14:34
c2a17a1 to
1472465
Compare
An image-only deploy carries no DAGs, so dags-path and no-dags-base-dir did nothing there, and the error for dbt and non-dags wrongly listed image-only as supported. All three options are new, so rejecting them breaks no existing workflow. Co-Authored-By: Claude <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds named DAG bundle deploys for Airflow 3 (Astro CLI 1.44.0+):
dag-bundle-name,dags-pathandno-dags-base-dir.dags-pathis resolved fromroot-folder, anddags-onlyclassifies changes against it instead ofdags/, so one repository can serve several bundles with one step each.dags-onlydeploy withdags-pathneeds no Astro project, so bundles can live outside it.inferwith either input, which would build the image for any change outside the bundle; these inputs withimage-only,dbt,non-dags, orimage-name; adags-paththat doesn't exist or leaves the repository.E2E: deploys a bundle from outside the Astro project, and checks that an unrelated DAG change doesn't deploy it and a dispatch does.