Response fixes - #1135
Open
swhite2401 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR propose 2 minor improvement for the response matrix interface:
1-OrbitResponseMatrix presently works only with KickAngle that is not defined in magnets elements by default. The user therefore has to first modify the lattice to use this function, this is not good. When the steerers list is provided by the user the default is now to act on K[ns]0L that are always defined.
A flag is provided to restore the previous behaviour when steerers are provided, when they are not the present behavior (use all element having KickAngle defined) is preserved
2-A warning is added in the calculation of the deviation when the target is not provided, this allows the user to correctly diagnose problems when the .correct() function is ineffective (targets not defined)