Repository navigation
feat(executor): add direct block execution for conditional blocks - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tryDirectBlockExecution()to evaluate#if/#unlessblocks directly without Handlebars renderingmap) when the selected branch resolves to a non-primitive valueWhy
Previously, wrapping a
mapcall inside{{#if condition}}...{{/if}}would cause Handlebars to stringify the array result. Direct block execution evaluates the condition and delegates to the existing type-preserving execution paths, so callers receive the raw array (or other typed value) instead of a string.Test plan
bun test tests/direct-block-execution.spec.ts— all 557-line suite passes#ifwith truthy/falsy conditions returns correct branch value#unlessinverts condition correctly