Conversation
Arcitec
force-pushed
the
fix-app-configs
branch
from
September 11, 2026 21:00
c5ee19b to
7f109e9
Compare
Author
|
To be clear, this fix is necessary and solves the following bug (which has been discussed in previous tickets): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous attempt at fixing this was incomplete and hacky (and doesn't work at all when run via Wine on Linux):
c2719b7
By default, the .NET runtime (on both Windows and Linux) only looks for libraries in the application's current folder or the Global Assembly Cache (GAC). In other words, plugins (custom assemblies) would have to be in the same directory as the EXE file, or in the global system location.
To allow applications to place assemblies anywhere, the specification says that we must extend the assembly probing path via the application configuration:
https://learn.microsoft.com/en-us/dotnet/framework/configure-apps/file-schema/runtime/probing-element
The correct method has now been applied to the app configurations, which makes Steamless work on Linux too, and improves the assembly loading on Windows. In fact, you can remove most of your custom assembly loading code from the older commit (you don't need the "Plugins" dir overriding anymore, and only need the "embedded plugins" detection code).
Hopefully this can make it into a quick release to fix this issue for everyone.
PS: This assembly loading path specification fix doesn't require any actual code changes, in case you don't want to spend time cleaning up/removing the old hack. 😸
Closes #75