Skip to content

fix(Table): fix grouped header alignment and duplicate key warnings & add regression tests - #268

Merged
seanrcollings merged 1 commit into
mainfrom
sc/267
Sep 16, 2026
Merged

seanrcollings merged 1 commit into
mainfrom
sc/267

Conversation

@seanrcollings

Copy link
Copy Markdown
Contributor

Resolves #267

Copilot AI lite review requested due to automatic review settings September 16, 2026 16:22

This comment was marked as resolved.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Placeholder keys can still collide, and the playground toggle does not reproduce the reported nested-header case.

Review details

Suppressed comments (1)

packages/atomic-elements/src/components/Content/Table/components/TableHeader.tsx:50

  • node.index is only assigned explicitly to real leaf clones in TableCollection; the synthetic placeholders created by buildHeaderRows are positioned by colIndex, and their index can be absent. That makes multiple placeholders in one row receive the same ...-undefined id, so the duplicate-key warning and stale-cell bug can remain. Use the placeholder's colIndex (or the callback's actual sibling index) for this position-based id.
          id={`${row.key}-placeholder-${node.index}`}
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 16, 2026 16:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

All reviewed changes are covered and no unresolved blocking issues remain.

Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@seanrcollings
seanrcollings merged commit 87c8d93 into main Sep 16, 2026
2 checks passed
@seanrcollings
seanrcollings deleted the sc/267 branch September 16, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table header rows grow when the column set changes

3 participants