fix(Table): fix grouped header alignment and duplicate key warnings & add regression tests - #268
Merged
Merged
Conversation
seanrcollings
force-pushed
the
sc/267
branch
from
September 16, 2026 16:31
33dc80d to
b965db5
Compare
seanrcollings
force-pushed
the
sc/267
branch
from
September 16, 2026 16:32
b965db5 to
b7d27cf
Compare
… add regression tests
seanrcollings
force-pushed
the
sc/267
branch
from
September 16, 2026 16:33
b7d27cf to
f97b28e
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
Placeholder keys can still collide, and the playground toggle does not reproduce the reported nested-header case.
Review details
Suppressed comments (1)
packages/atomic-elements/src/components/Content/Table/components/TableHeader.tsx:50
node.indexis only assigned explicitly to real leaf clones inTableCollection; the synthetic placeholders created bybuildHeaderRowsare positioned bycolIndex, and theirindexcan be absent. That makes multiple placeholders in one row receive the same...-undefinedid, so the duplicate-key warning and stale-cell bug can remain. Use the placeholder'scolIndex(or the callback's actual sibling index) for this position-based id.
id={`${row.key}-placeholder-${node.index}`}
- Files reviewed: 4/4 changed files
- Comments generated: 0 new
- Review effort level: Lite
blunckr-aj
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #267