Make clean and package target for nrf52 platform also run on Windows - #106
Open
bobby-mcbuilder wants to merge 1 commit into
Open
Make clean and package target for nrf52 platform also run on Windows#106bobby-mcbuilder wants to merge 1 commit into
bobby-mcbuilder wants to merge 1 commit into
Conversation
* replacing shell commands with SCons file actions * using PlatformIOs $PYTHONEXE for Python scripts * pathlib for filesystem path handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem to Solve
Wanted to upload latest changes, in my case the "Airtime Limit" feature, to wiscore_rak4631 environmenent on Win11.
Realized that extra_script.py heavily relies on Posix shell-commands, but PlatformIO, SCons and Python don't.
Proposed Solution
In a first step make clean and package target for nrf52 also run on Windows. This is already useful to upload the resulting zip-file with the Web-Installer. The upload target is for another pull-request.
Other Solutions
Python's subprocess module with output-redirection to run release_hashes.py (proposed solution still relies on shell)
Testing
Environments:
Host Platforms:
User-facing changes
A few build log-lines changed slightly (lines about rm, mkdir, cp...)
Additional Dependencies
pathlib (Python built-in)
Edit: removed comments about zip-file handling as it is not involved in this pull-request