Repository navigation
libretro: Default the video mode to Color TV - #431
Merged
Merged
Conversation
Video Mode was the only system option without a default, so frontends took the first value, Color (RGB Card/Monitor). Use Color TV, the same as VT_DEFAULT in the desktop build.
Owner
|
I saw the same yesterday and I was blaming my first ubuntu 26.04 build, but now it deserves an investigation. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video Mode is the only system option without a default, so a frontend that uses the options' defaults gets the first value, Color (RGB Card/Monitor). This sets it to Color TV, the same as
VT_DEFAULTin the desktop build.I noticed because The Dark Crystal (Sierra) shows coloured bands rolling up the screen at its "insert disk #1, side B" prompt in RGB mode. Left is the current default, right is with this change, both running on the core's own defaults:
I can't tell whether the bands are what an RGB card would really do with this game or something in the RGB emulation, so this only changes the default.